linux-kernel - Re: [PATCH 3/3] staging: brcm80211: fix to use "%pM" flag to print MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Oct 2010 15:25:04 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Nohee Ko <noheek@...adcom.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 3/3] staging: brcm80211: fix to use "%pM" flag to print
 MAC address

On Sun, Oct 10, 2010 at 1:44 PM, Johannes Berg
<johannes@...solutions.net> wrote:
>> +     snprintf(buf, 18, "%pM", ea->octet);
>
> That's a pretty strange use of snprintf -- just use sprintf if you don't
> have a real buffer length.
Exactly. However, it's out of scope of this certain patch.

It should be done as a fix across entire driver.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/