lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 10 Oct 2010 17:58:39 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Greg KH <greg@...ah.com>
CC:	Alon Ziv <alon+git@...aviz.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Add Opticon OPN2001 write support

Hello.

On 10/10/10 16:34, Greg KH wrote:

>>> OPN2001 expects write operations to arrive as a vendor-specific command
>>> through the control pipe (instead of using a separate bulk-out pipe).

>>> Signed-off-by: Alon Ziv<alon-git@...aviz.org>
>>> ---
>>>    drivers/usb/serial/opticon.c |   30 ++++++++++++++++++++++++++----
>>>    1 files changed, 26 insertions(+), 4 deletions(-)

>>> diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
>>> index 9ff19c8..4fe7c3d 100644
>>> --- a/drivers/usb/serial/opticon.c
>>> +++ b/drivers/usb/serial/opticon.c
>> [...]

>>> +	} else {
>>> +		struct usb_ctrlrequest *dr;
>>> +
>>> +		dr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_NOIO);

>>     sizeof(*dr) is a preferred form.

> No, people disagree on this, there is no 'preferred' form, you are free
> to use either way.

    Please refer to the CodingStyle chapter 14. This is preferred form, 
according to it...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists