linux-kernel - Re: [PATCHv2 2/3] iovmm: add superpages support to fixed da address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Oct 2010 14:09:10 +0300
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	"Guzman Lugo, Fernando" <fernando.lugo@...com>
Cc:	"Hiroshi.DOYU@...ia.com" <Hiroshi.DOYU@...ia.com>,
	"david.cohen@...ia.com" <david.cohen@...ia.com>,
	"felipe.contreras@...ia.com" <felipe.contreras@...ia.com>,
	"ameya.palande@...ia.com" <ameya.palande@...ia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCHv2 2/3] iovmm: add superpages support to fixed da address

On Mon, Oct 11, 2010 at 6:33 PM, Guzman Lugo, Fernando
<fernando.lugo@...com> wrote:
>> > @@ -420,7 +431,8 @@ static void sgtable_fill_kmalloc(struct
>> sg_table
>> > *sgt, u32 pa, size_t len)
>> >        for_each_sg(sgt->sgl, sg, sgt->nents, i) {
>> >                size_t bytes;
>> >
>> > -               bytes = iopgsz_max(len);
>> > +               bytes = max_alignment(da | pa);
>> > +               bytes = min(bytes, (size_t)iopgsz_max(len));
>>
>> Why the size_t casting?
>
> To void this warning:
> arch/arm/plat-omap/iovmm.c:440: warning: comparison of distinct pointer types lacks a cast

But how is that possible? iopgsz_max is returning constants, like
SZ_1M, so they should not need casts, if anything, the cast should be
done in iopgsz_max itself.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/