linux-kernel - Re: [PATCH] ath5k: fix build break from "ath5k: Print out opmode in debugfs"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Oct 2010 16:31:32 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	"John W. Linville" <linville@...driver.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-wireless@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ath5k: fix build break from "ath5k: Print out opmode
 in debugfs"

On 10/12/2010 11:18 AM, John W. Linville wrote:
> On Tue, Oct 12, 2010 at 11:13:31AM -0700, Linus Torvalds wrote:
>> On Tue, Oct 12, 2010 at 7:53 AM, John W. Linville
>> <linville@...driver.com>  wrote:
>>>
>>> Please don't make me commit such an ugly patch...
>>
>>   Why don't you just create a dummy inline ath_opmode_to_string() that
>> returns NULL in the non-debug case? The compiler will make the
>> conditionals all go away, and it will end up being "UNKNOWN" which is
>> just what you want. No?
>
> Shhh!  Your messing-up my manipulative mind games! :-)

Looks like this was my bug, and I lost these emails in a folder
I don't read so often.

If you're not happy with the fixes posted, let me know and
I'll work on one.

Thanks,
Ben


-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/