linux-kernel - Re: [PATCH -next] edac/mce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Oct 2010 06:24:09 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Doug Thompson <dougthompson@...ssion.com>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] edac/mce_amd: fix shift warning

From: Randy Dunlap <randy.dunlap@...cle.com>
Date: Wed, Oct 13, 2010 at 04:10:57PM -0400

> The BIT() macro works on unsigned longs, but this warning happens
> on i386 (X86_32), where UL is 32 bits and this value needs to be
> 64 bits, so use open-coded ULL.
> 
> drivers/edac/mce_amd.c:262: warning: left shift count >= width of type

Ok, so BIT() should be fixed to work with the largest type available,
IMHO. Let me cook up something.

> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Doug Thompson <dougthompson@...ssion.com>
> Cc: Borislav Petkov <borislav.petkov@....com>

In the meantime, I'll push your fix to Linus, thanks for testing this on
32-bit :).

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/