| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Oct 2010 18:41:28 +0400 From: Vasiliy Kulikov <segooon@...il.com> To: kernel-janitors@...r.kernel.org Cc: Andrew Morton <akpm@...ux-foundation.org>, Julia Lawall <julia@...u.dk>, Tejun Heo <tj@...nel.org>, Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org Subject: [PATCH 5/8] char: ppdev: fix information leak to userland Structure par_timeout is copied to userland with some padding fields unitialized. Field tv_usec has type __kernel_suseconds_t, it differs from tv_sec's type on some architectures. It leads to leaking of stack memory. Signed-off-by: Vasiliy Kulikov <segooon@...il.com> --- Compile tested. drivers/char/ppdev.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c index 723152d..f176dba 100644 --- a/drivers/char/ppdev.c +++ b/drivers/char/ppdev.c @@ -613,6 +613,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case PPGETTIME: to_jiffies = pp->pdev->timeout; + memset(&par_timeout, 0, sizeof(par_timeout)); par_timeout.tv_sec = to_jiffies / HZ; par_timeout.tv_usec = (to_jiffies % (long)HZ) * (1000000/HZ); if (copy_to_user (argp, &par_timeout, sizeof(struct timeval))) -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists