linux-kernel - Re: 2.6.36-rc8 -- drivers/built-in.o: In function `nouveau_acpi_edid': (.text+0xf7c04): undefined reference to `acpi_video_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Oct 2010 21:00:35 -0400
From:	Miles Lane <miles.lane@...il.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ben Skeggs <bskeggs@...hat.com>,
	Maarten Maathuis <madman2003@...il.com>
Subject: Re: 2.6.36-rc8 -- drivers/built-in.o: In function `nouveau_acpi_edid':
 (.text+0xf7c04): undefined reference to `acpi_video_get_edid'

On Sat, Oct 16, 2010 at 4:58 PM, Roland Dreier <rdreier@...co.com> wrote:
>  > drivers/built-in.o: In function `nouveau_acpi_edid':
>  > (.text+0xf7c04): undefined reference to `acpi_video_get_edid'
>  > make: *** [.tmp_vmlinux1] Error 1
>
> The problem is:
>
>  > CONFIG_ACPI=y
>  > CONFIG_ACPI_VIDEO=m
>
> but
>
>  > CONFIG_DRM_NOUVEAU=y
>
> So the built-in nouveau code tries to reference the modular acpi video
> code.  I'm not sure what the correct fix is... does the following make
> things work?
>
>  drivers/gpu/drm/nouveau/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/Makefile b/drivers/gpu/drm/nouveau/Makefile
> index e9b06e4..4e295b5 100644
> --- a/drivers/gpu/drm/nouveau/Makefile
> +++ b/drivers/gpu/drm/nouveau/Makefile
> @@ -28,6 +28,6 @@ nouveau-y := nouveau_drv.o nouveau_state.o nouveau_channel.o nouveau_mem.o \
>  nouveau-$(CONFIG_DRM_NOUVEAU_DEBUG) += nouveau_debugfs.o
>  nouveau-$(CONFIG_COMPAT) += nouveau_ioc32.o
>  nouveau-$(CONFIG_DRM_NOUVEAU_BACKLIGHT) += nouveau_backlight.o
> -nouveau-$(CONFIG_ACPI) += nouveau_acpi.o
> +nouveau-$(CONFIG_ACPI_VIDEO) += nouveau_acpi.o
>
>  obj-$(CONFIG_DRM_NOUVEAU)+= nouveau.o
>

Hi Roland,

I tried with your patch applied and got this:

drivers/built-in.o: In function `load_vbios_acpi':
nouveau_bios.c:(.text+0xa9cdf): undefined reference to
`nouveau_acpi_rom_supported'
nouveau_bios.c:(.text+0xa9cf4): undefined reference to
`nouveau_acpi_get_bios_chunk'
drivers/built-in.o: In function `nouveau_connector_detect_lvds':
nouveau_connector.c:(.text+0xb49d4): undefined reference to `nouveau_acpi_edid'
drivers/built-in.o: In function `nouveau_init':
nouveau_drv.c:(.init.text+0x653e): undefined reference to
`nouveau_register_dsm_handler'
drivers/built-in.o: In function `nouveau_exit':
nouveau_drv.c:(.exit.text+0x19b): undefined reference to
`nouveau_unregister_dsm_handler'
make: *** [.tmp_vmlinux1] Error 1

When I set CONFIG_DRM_NOUVEAU=m rather than =y, I got this:

ERROR: "nouveau_register_dsm_handler"
[drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: "nouveau_acpi_rom_supported"
[drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: "nouveau_unregister_dsm_handler"
[drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: "nouveau_acpi_get_bios_chunk"
[drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: "nouveau_acpi_edid" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/