linux-kernel - Re: [PATCH 2/3] usb: trivial Kconfig cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Oct 2010 11:29:41 +0300
From:	Felipe Balbi <balbi@...com>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	"Balbi, Felipe" <balbi@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	linux-main <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH 2/3] usb: trivial Kconfig cleanups

On Tue, Oct 19, 2010 at 03:25:27AM -0500, Felipe Contreras wrote:
>On Tue, Oct 19, 2010 at 11:15 AM, Felipe Balbi <balbi@...com> wrote:
>> On Tue, Oct 19, 2010 at 03:04:25AM -0500, Felipe Contreras wrote:
>>>
>>> @@ -125,14 +125,6 @@ config USB_MUSB_OTG
>>>
>>> endchoice
>>>
>>> -# enable peripheral support (including with OTG)
>>> -config USB_GADGET_MUSB_HDRC
>>> -       bool
>>> -       depends on USB_MUSB_HDRC && (USB_MUSB_PERIPHERAL || USB_MUSB_OTG)
>>> -#      default y
>>> -#      select USB_GADGET_DUALSPEED
>>> -#      select USB_GADGET_SELECTED
>>> -
>>
>> $ git grep -e CONFIG_USB_GADGET_MUSB_HDRC drivers/usb/
>> drivers/usb/gadget/gadget_chips.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/Makefile:ifeq ($(CONFIG_USB_GADGET_MUSB_HDRC),y)
>> drivers/usb/musb/am35x.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/da8xx.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.c:#endif /* CONFIG_USB_GADGET_MUSB_HDRC */
>> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.c:#elif defined(CONFIG_USB_GADGET_MUSB_HDRC)
>> drivers/usb/musb/musb_core.h:#ifndef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.h:#error bogus Kconfig output ... select
>> CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/musb_core.h:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/tusb6010.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/tusb6010.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>> drivers/usb/musb/tusb6010.c:#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>
>So?
>
>% git grep USB_GADGET_MUSB_HDRC -- '*/Kconfig'
>drivers/usb/gadget/Kconfig:config USB_GADGET_MUSB_HDRC
>drivers/usb/musb/Kconfig:# use USB_GADGET_MUSB_HDRC not
>USB_MUSB_PERIPHERAL to #ifdef peripheral
>drivers/usb/musb/Kconfig:       select USB_GADGET_MUSB_HDRC
>drivers/usb/musb/Kconfig:       select USB_GADGET_MUSB_HDRC
>drivers/usb/musb/Kconfig:config USB_GADGET_MUSB_HDRC
>drivers/usb/musb/Kconfig:       select USB_OTG if USB_GADGET_MUSB_HDRC
>
>(it's defined twice)

you're right, had missed that. This is ok too.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/