linux-kernel - Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Oct 2010 16:40:37 +0300
From:	Roger Quadros <roger.quadros@...ia.com>
To:	ext Felipe Contreras <felipe.contreras@...il.com>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	linux-main <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Felipe Balbi <balbi@...com>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

Hi Felipe,

On 10/19/2010 01:03 PM, ext Felipe Contreras wrote:
> Add missing dependencies, and remove redundant ones, and select sensible
> defaults.
>
> Signed-off-by: Felipe Contreras<felipe.contreras@...il.com>
> ---
>   drivers/mfd/Kconfig        |    3 ++-
>   drivers/regulator/Kconfig  |    1 +
>   drivers/usb/gadget/Kconfig |    3 +--
>   drivers/usb/musb/Kconfig   |    6 ++----
>   drivers/usb/otg/Kconfig    |    2 ++
>   5 files changed, 8 insertions(+), 7 deletions(-)
>

> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index c530bc6..2aac57e 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -111,7 +111,6 @@ config	USB_GADGET_SELECTED
>   #
>   choice
>   	prompt "USB Peripheral Controller"
> -	depends on USB_GADGET
>   	help
>   	   A USB device uses a controller to talk to its host.
>   	   Systems should have only one such upstream link.
> @@ -191,7 +190,6 @@ config USB_GADGET_OMAP
>   	boolean "OMAP USB Device Controller"
>   	depends on ARCH_OMAP
>   	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> -	select USB_OTG_UTILS if ARCH_OMAP
>   	help
>   	   Many Texas Instruments OMAP processors have flexible full
>   	   speed USB device controllers, with support for up to 30
> @@ -843,6 +841,7 @@ config USB_CDC_COMPOSITE
>   config USB_G_NOKIA
>   	tristate "Nokia composite gadget"
>   	depends on PHONET
> +	depends on USB_GADGET_MUSB_HDRC

This is wrong. Is there a build problem or run-time problem without this?

-- 
regards,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/