linux-kernel - Re: [RFC] Removal of dead code from arch/arm/*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Oct 2010 10:19:42 +0200
From:	Zimny Lech <napohybelskurwysynom2010@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Eric Miao <eric.y.miao@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] Removal of dead code from arch/arm/*

2010/10/21 Russell King - ARM Linux <linux@....linux.org.uk>:
> On Thu, Oct 21, 2010 at 02:39:55AM +0200, N.P.S. wrote:
>> diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c
>> index 38c261f..fd30b75 100644
>> --- a/arch/arm/kernel/time.c
>> +++ b/arch/arm/kernel/time.c
>> @@ -37,13 +37,9 @@
>>   */
>>  struct sys_timer *system_timer;
>>
>> -#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE)
>> +#if defined(CONFIG_RTC_DRV_CMOS)
>>  /* this needs a better home */
>>  DEFINE_SPINLOCK(rtc_lock);
>> -
>> -#ifdef CONFIG_RTC_DRV_CMOS_MODULE
>> -EXPORT_SYMBOL(rtc_lock);
>> -#endif
>>  #endif    /* pc-style 'CMOS' RTC support */
>>
>>  /* change this if you have some constant time drift */
>
> This is wrong, and will break the build if rtc-cmos is built as a module.
>

Indeed, sorry, I checked use of RTC_DRV_CMOS_MODULE and I should check
RTC_DRV_CMOS

I tried to cross compile allyesconfig to test my changes and I hit this
  CC      drivers/gpio/janz-ttl.o
drivers/gpio/janz-ttl.c: In function ‘ttl_set_value’:
drivers/gpio/janz-ttl.c:107: error: implicit declaration of function
‘iowrite16be’

-- 
Slawa!
N.P.S.

Les fleurs du mal unfold
Comme les fleurs du mal
Dark demons of my soul
Un amour fatal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/