linux-kernel - Re: [PATCH] POWER: Add gpio chager driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Oct 2010 19:05:54 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	rklein@...dia.com, broonie@...nsource.wolfsonmicro.com,
	achew@...dia.com, olof@...om.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] POWER: Add gpio chager driver

On Thu, Oct 21, 2010 at 04:52:37PM +0200, Lars-Peter Clausen wrote:
[...]
> >> +	gpio_charger->irq = gpio_to_irq(pdata->gpio);
> >> +	if (gpio_charger->irq >= 0) {
> > 
> > 0 isn't valid IRQ number. The check should be just 'if (gpio_charger->irq)'.
> 
> While it is unlikely to be used for an gpio IRQ, as far as I know 0 is a valid IRQ
> number.

0 may be a valid HW IRQ, but not VIRQ.

http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg22857.html

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/