linux-kernel - Re: [PATCH] rivafb: dubious assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Oct 2010 16:47:02 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Nicolas Kaiser <nikai@...ai.net>, Jeff Garzik <jgarzik@...ox.com>
Cc:	Antonino Daplas <adaplas@...il.com>, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rivafb: dubious assignment

On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser <nikai@...ai.net> wrote:
> A duplicated assignment unconditionally changes max_gfsize to
> GFIFO_SIZE.
>
> It looks to me like this might not be intended, or is it?
>
> Signed-off-by: Nicolas Kaiser <nikai@...ai.net>
> ---
>  drivers/video/riva/riva_hw.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
> index 78fdbf5..936abfa 100644
> --- a/drivers/video/riva/riva_hw.c
> +++ b/drivers/video/riva/riva_hw.c
> @@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
>     vmisses = 2;
>     if (ainfo->gburst_size == 128) max_gfsize = GFIFO_SIZE_128;
>     else  max_gfsize = GFIFO_SIZE;
> -    max_gfsize = GFIFO_SIZE;
>     while (1)
>     {
>         if (ainfo->vid_en)
> --
> 1.7.2.2

According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
from nVidia code(?), imported by Jeff Garzik.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/