linux-kernel - Re: [PATCH] time: jiffies.c: fix typos in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Oct 2010 13:01:39 -0400
From:	Kyle Moffett <kyle@...fetthome.net>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Serafeim Zanikolas <sez@...ian.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: jiffies.c: fix typos in comment

On Sun, Oct 24, 2010 at 10:22, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Sat, 23 Oct 2010, Serafeim Zanikolas wrote:
>> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
>> index 5404a84..12ba9a7 100644
>> --- a/kernel/time/jiffies.c
>> +++ b/kernel/time/jiffies.c
>> @@ -30,8 +30,8 @@
>>   * the timer interrupt frequency HZ and it suffers
>>   * inaccuracies caused by missed or lost timer
>>   * interrupts and the inability for the timer
>> - * interrupt hardware to accuratly tick at the
>> - * requested HZ value. It is also not reccomended
>> + * interrupt hardware to accurately tick at the
>> + * requested HZ value. It is also not recommended
>>   * for "tick-less" systems.
>
> You are not only correcting a typo. You are changing the sense of the
> comment, unfortunately in the wrong way.
>
> Why wouldn't it be recommended that the interrupt hardware ticks at
> the requested HZ value ?
>
> The inability of it to tick accurately at the requested HZ value is
> one of the causes which make jiffies clocksource inaccurate. And that
> what the comment says.

Thomas,

Please reread the patch again, I think it does exactly what he said it
did.  Specifically, the old text is:
>>   * the timer interrupt frequency HZ and it suffers
>>   * inaccuracies caused by missed or lost timer
>>   * interrupts and the inability for the timer
>>   * interrupt hardware to accuratly tick at the
>>   * requested HZ value. It is also not reccomended
>>   * for "tick-less" systems.

While the new text is:
>>   * the timer interrupt frequency HZ and it suffers
>>   * inaccuracies caused by missed or lost timer
>>   * interrupts and the inability for the timer
>>   * interrupt hardware to accurately tick at the
>>   * requested HZ value. It is also not recommended
>>   * for "tick-less" systems.

I misread it the first time myself, mentally combining the second line
of the old text with the new text; what you probably saw was:

>> - * requested HZ value. It is also not reccomended
>> + * interrupt hardware to accurately tick at the
>> + * requested HZ value.

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/