linux-kernel - [PATCH]: char, mxser: Fix compilation warning in mxser.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 25 Oct 2010 13:14:15 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Slaby <jirislaby@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Kulikov Vasiliy <segooon@...il.com>
Subject: [PATCH]: char, mxser: Fix compilation warning in mxser.c

Both function mxser_disable_must_enchance_mode() and
mxser_get_must_hardware_id() called from function CheckIsMoxaMust(),
when CONFIG_PCI=y. So mark both the functions under CONFIG_PCI.

We were warned by the following warning.

drivers/char/mxser.c:306: warning: ‘mxser_disable_must_enchance_mode’
defined but not used
drivers/char/mxser.c:391: warning: ‘mxser_get_must_hardware_id’
defined but not used


Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
---

diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index 3fc89da..2bdadd4 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -303,6 +303,7 @@ static void
mxser_enable_must_enchance_mode(unsigned long baseio)
 	outb(oldlcr, baseio + UART_LCR);
 }

+#ifdef	CONFIG_PCI
 static void mxser_disable_must_enchance_mode(unsigned long baseio)
 {
 	u8 oldlcr;
@@ -317,6 +318,7 @@ static void
mxser_disable_must_enchance_mode(unsigned long baseio)
 	outb(efr, baseio + MOXA_MUST_EFR_REGISTER);
 	outb(oldlcr, baseio + UART_LCR);
 }
+#endif

 static void mxser_set_must_xon1_value(unsigned long baseio, u8 value)
 {
@@ -388,6 +390,7 @@ static void mxser_set_must_enum_value(unsigned
long baseio, u8 value)
 	outb(oldlcr, baseio + UART_LCR);
 }

+#ifdef CONFIG_PCI
 static void mxser_get_must_hardware_id(unsigned long baseio, u8 *pId)
 {
 	u8 oldlcr;
@@ -404,6 +407,7 @@ static void mxser_get_must_hardware_id(unsigned
long baseio, u8 *pId)
 	*pId = inb(baseio + MOXA_MUST_HWID_REGISTER);
 	outb(oldlcr, baseio + UART_LCR);
 }
+#endif

 static void SET_MOXA_MUST_NO_SOFTWARE_FLOW_CONTROL(unsigned long baseio)
 {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/