lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Oct 2010 18:35:45 -0700 From: Joe Perches <joe@...ches.com> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: Jiri Kosina <trivial@...nel.org>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use On Tue, 2010-10-26 at 18:28 -0700, Dmitry Torokhov wrote: > On Oct 26, 2010, at 6:10 PM, Joe Perches <joe@...ches.com> wrote: > > I think 2 defects in 16 uses is a pretty high error rate. > But how not adding /n is it much better than having it if > some later change will forget to add it to the message? Adding \n is the default kernel style. USB uses a similar dbg macro with a relatively high error rate. I fixed some in this commit below awhile ago, but these keep creeping back in, so they _are_ error prone in actual use. commit 759f3634267a67ac90f3fa7fc06510dfd43b4e45 Author: Joe Perches <joe@...ches.com> Date: Fri Feb 5 16:50:08 2010 -0800 USB: serial: Remove unnecessary \n's from dbg uses #define dbg adds the newline, messages shouldn't. Converted dbg("%s", "some string") to dbg("some string") Signed-off-by: Joe Perches <joe@...ches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists