linux-kernel - Re: [PATCH 9/14] sound/oss/sb_ess.c: delete double assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Oct 2010 09:13:35 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Julia Lawall <julia@...u.dk>
Cc:	Jaroslav Kysela <perex@...ex.cz>, kernel-janitors@...r.kernel.org,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/14] sound/oss/sb_ess.c: delete double assignment

At Tue, 26 Oct 2010 12:25:38 +0200,
Julia Lawall wrote:
> 
> From: Julia Lawall <julia@...u.dk>
> 
> Delete successive assignments to the same location.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression i;
> @@
> 
> *i = ...;
>  i = ...;
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Thanks, applied now.


Takashi

> ---
>  sound/oss/sb_ess.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/oss/sb_ess.c b/sound/oss/sb_ess.c
> index 51a3d38..9890cf2 100644
> --- a/sound/oss/sb_ess.c
> +++ b/sound/oss/sb_ess.c
> @@ -1722,7 +1722,6 @@ printk (KERN_INFO "FKS: es_rec_set_recmask mask = %x\n", mask);
>  				right = (value & 0x0000ff00) >> 8;
>  			} else {				/* Turn it off (3)  */
>  				left  = 0;
> -				left  = 0;
>  				right = 0;
>  			}
>  			sb_common_mixer_set(devc, i + ES_REC_MIXER_RECDIFF, left, right);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/