linux-kernel - Re: [PATCH] tracing: fix TRACE_EVENT power tracepoint creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Oct 2010 08:53:44 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: fix TRACE_EVENT power tracepoint creation

On Thu, 2010-10-28 at 07:03 -0400, Mathieu Desnoyers wrote:

> Given that trace/power.h is inluded in more than one .c file, generating
> DEFINE_TRACE() when CREATE_TRACE_POINTS is not set does not work. So what
> alternative do you suggest ?

Right, DEFINE_TRACE should only be set when CREATE_TRACE_POINTS is set,
and that is only set in the C file that the DEFINE_TRACE is to be
defined.

In fact, I don't even see what bug you are trying to fix?

The file include/trace/define_trace.h converts all the TRACE_EVENTS()
into DEFINE_TRACE() when CREATE_TRACE_POINTS is set. No other C file
that includes power.h should have CREATE_TRACE_POINTS set. I guess if it
did, the CONFIG_EVENT_TRACING would break too.

It should just work.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/