linux-kernel - Re: [PATCH] fix amiga and atari floppy driver compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Oct 2010 20:46:18 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Jens Axboe <jaxboe@...ionio.com>,
	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	linux-m68k@...r.kernel.org, hch@....de
Subject: Re: [PATCH] fix amiga and atari floppy driver compile warning

On Thu, Oct 28, 2010 at 20:42, Vivek Goyal <vgoyal@...hat.com> wrote:
> Geert, my crosstool don't produce warning below. I guess this has to do
> something with compiler version.
>
> - Geert noticed following warning during compilation.
>
>  drivers/block/amiflop.c:1344: warning: ‘rq’ may be used uninitialized in
>  this function
>  drivers/block/ataflop.c:1402: warning: ‘rq’ may be used uninitialized in
>  this function
>
> - Initialize rq to NULL to fix the warning. If we can't find a suitable request
>  to dispatch, this function should return NULL instead of a possibly garbage
>  pointer.

Thanks, gcc version 4.1.2 20061115 now no longer gives a warning.

> - Cross compile tested only. Don't have hardware to test it.

Floppy hardware in bad state here :-(

> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Vivek Goyal <vgoyal@...hat.com>
> ---
>  drivers/block/amiflop.c |    2 +-
>  drivers/block/ataflop.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/drivers/block/amiflop.c
> ===================================================================
> --- linux-2.6.orig/drivers/block/amiflop.c      2010-10-28 14:32:25.000000000 -0400
> +++ linux-2.6/drivers/block/amiflop.c   2010-10-28 14:34:11.000000000 -0400
> @@ -1341,7 +1341,7 @@ static struct request *set_next_request(
>  {
>        struct request_queue *q;
>        int cnt = FD_MAX_UNITS;
> -       struct request *rq;
> +       struct request *rq = NULL;
>
>        /* Find next queue we can dispatch from */
>        fdc_queue = fdc_queue + 1;
> Index: linux-2.6/drivers/block/ataflop.c
> ===================================================================
> --- linux-2.6.orig/drivers/block/ataflop.c      2010-10-28 14:31:21.000000000 -0400
> +++ linux-2.6/drivers/block/ataflop.c   2010-10-28 14:33:58.000000000 -0400
> @@ -1399,7 +1399,7 @@ static struct request *set_next_request(
>  {
>        struct request_queue *q;
>        int old_pos = fdc_queue;
> -       struct request *rq;
> +       struct request *rq = NULL;
>
>        do {
>                q = unit[fdc_queue].disk->queue;
>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/