linux-kernel - Re: [PATCH] Staging: frontier: alphatrack: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Nov 2010 06:32:50 -0700
From:	Greg KH <greg@...ah.com>
To:	Audun Hoem <audun.hoem@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: frontier: alphatrack: Fixed coding style
	issues

On Tue, Nov 02, 2010 at 10:43:44AM +0100, Audun Hoem wrote:
> From: audun <audun.hoem@...il.com>

Minor nit, use your full name here in the From: line.

> 
> I cleaned up the coding style.
> 
> Signed-off-by: Audun Hoem <audun.hoem@...il.com>

Like you used here, that's the correct thing to put here.



> ---
>  drivers/staging/frontier/alphatrack.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/frontier/alphatrack.c b/drivers/staging/frontier/alphatrack.c
> index ef7fbf8..9d439fa 100644
> --- a/drivers/staging/frontier/alphatrack.c
> +++ b/drivers/staging/frontier/alphatrack.c
> @@ -88,8 +88,11 @@ MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface");
>  static int debug = ALPHATRACK_DEBUG;
>  
>  /* Use our own dbg macro */
> -#define dbg_info(dev, format, arg...) do \
> -    { if (debug) dev_info(dev , format , ## arg); } while (0)
> +#define dbg_info(dev, format, arg...) \
> +do {
> +	if (debug)
> +		dev_info(dev , format , ## arg);
> +} while (0)

In the future, you can probably just remove this macro and switch the
dev_info() users in the driver to use dev_dbg() as it handles the debug
toggle already.  Then you can remove the debug variable as well as the
debugging is handled by the dynamic debug core code in the kernel.

Thanks for the patch, I'll queue it up later and you will get an
automated email when it goes into my tree.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/