linux-kernel - Re: suspend fails on x200 (was Re: [PATCH] tpm: Autodetect itpm devices)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Nov 2010 18:31:06 -0700
From:	Andy Isaacson <adi@...apodia.org>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	srajiv@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: suspend fails on x200 (was Re: [PATCH] tpm: Autodetect itpm
	devices)

On Mon, Nov 01, 2010 at 09:32:24PM +0000, Matthew Garrett wrote:
> On Mon, Nov 01, 2010 at 02:19:48PM -0700, Andy Isaacson wrote:
> > I suspect that it would have failed previously if I'd forced the module
> > to load, but since tpm_tis now loads automatically as of 2.6.37-rc1, I
> > have to "rmmod tpm_tis" for suspend to work.
> 
> Hm. That's what this patch was intended to fix. Can you check that the 
> tree you're using has it merged? The autoloading comes from the fix to 
> the pnp code to use _CID even if _HID is malformed, so now we have a pnp 
> device when we previously didn't.

Hmmm, I am testing with straight-up .37-rc1, c8ddb2713c62.  It does not
include your patch.

This time around, still running -rc1, I ran pm-suspend and it suspended
+ resumed fine.  The second time I ran pm-suspend, it switched to text
console and started flashing the moon LED, but hung there with the LCD
backlight still on and the LED moon flashing.

So, definitely something exciting going on... and not a simple
suspend regression, and definitely not caused by this patch, my
apologies.  Subject line updated accordingly.

I'll try applying "Autodetect itpm devices" and report back.

-andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/