lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 2 Nov 2010 21:06:56 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Brandon Philips <brandon@...p.org>
CC:	Hank Janssen <hjanssen@...rosoft.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>
Subject: RE: [PATCH 05/10] staging: hv: Convert camel cased functions in
 hv.c to lower cases

> From: Brandon Philips [mailto:brandon@...p.org]
> Sent: Tuesday, November 02, 2010 1:04 PM
> > -static int HvQueryHypervisorInfo(void)
> > +static int hvquery_hypervisor_info(void)
> > -static u64 HvDoHypercall(u64 control, void *input, void *output)
> > +static u64 hvdo_hypercall(u64 control, void *input, void *output)
> 
> Should these be hv_do_hypercall and hv_query_hypervisor? That seems to
> be the style in the rest of the patch:

I didn't insert underscore between every word, for example, it's not
added between two short words.

Thanks,
- Haiyang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ