linux-kernel - Re: [PATCH] Add Kconfig option for default swappiness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Nov 2010 13:27:41 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Ben Gamari <bgamari.foss@...il.com>
Cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Jesper Juhl <jj@...osbits.net>,
	Wu Fengguang <fengguang.wu@...el.com>
Subject: Re: [PATCH] Add Kconfig option for default swappiness

On Tue, Nov 2, 2010 at 12:20 PM, Ben Gamari <bgamari.foss@...il.com> wrote:
> This will allow distributions to tune this important vm parameter in a more
> self-contained manner.
>
> Signed-off-by: Ben Gamari <bgamari.foss@...il.com>
> Acked-by: Johannes Weiner <hannes@...xchg.org>
> Acked-by: Wu Fengguang <fengguang.wu@...el.com>
> ---
>  Documentation/sysctl/vm.txt |    2 +-
>  mm/Kconfig                  |   14 ++++++++++++++
>  mm/vmscan.c                 |    2 +-
>  3 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt
> index 30289fa..d159d02 100644
> --- a/Documentation/sysctl/vm.txt
> +++ b/Documentation/sysctl/vm.txt
> @@ -643,7 +643,7 @@ This control is used to define how aggressive the kernel will swap
>  memory pages.  Higher values will increase agressiveness, lower values
>  decrease the amount of swap.
>
> -The default value is 60.
> +The default value is 60 (changed with CONFIG_DEFAULT_SWAPINESS).
>
>  ==============================================================
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index c2c8a4a..dc23737 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -61,6 +61,20 @@ config SPARSEMEM_MANUAL
>
>  endchoice
>
> +config DEFAULT_SWAPPINESS
> +       int "Default swappiness"
> +       default "60"
> +       range 0 100
> +       help
> +         This control is used to define how aggressive the kernel will swap
> +         memory pages.  Higher values will increase agressiveness, lower
> +         values decrease the amount of swap. Valid values range from 0 to 100.
> +
> +         This only sets the default value at boot. Swappiness can be set at
> +         runtime through /proc/sys/vm/swappiness.
> +
> +         If unsure, keep default value of 60.
> +
>  config DISCONTIGMEM
>        def_bool y
>        depends on (!SELECT_MEMORY_MODEL && ARCH_DISCONTIGMEM_ENABLE) || DISCONTIGMEM_MANUAL
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b8a6fdc..d9f5bba 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -133,7 +133,7 @@ struct scan_control {
>  /*
>  * From 0 .. 100.  Higher means more swappy.
>  */
> -int vm_swappiness = 60;
> +int vm_swappiness = CONFIG_DEFAULT_SWAPPINESS;
>  long vm_total_pages;   /* The total number of pages which the VM controls */
>
>  static LIST_HEAD(shrinker_list);

Apparently, it wouldn't hurt maintain the kernel. But I have a concern.
As someone think this parameter is very important and would be better
to control by kernel config rather than init script to make the
package, it would make new potential kernel configs by someone in
future.
But I can't convince my opinion myself. Because if there will be lots
of kernel config for tuning parameters, could it hurt
maintain/usability? I can't say "Yes" strongly. so I am not against
this idea strongly.
Hmm,,  Just pass the decision to others.

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/