linux-kernel - Re: [PATCH 1/1] PCI: xen-pcifront, fix PCI reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Nov 2010 12:27:07 -0600
From:	Milton Miller <miltonm@....com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	jbarnes@...tuousgeek.org, linux-pci@...r.kernel.org,
	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org,
	jirislaby@...il.com, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH 1/1] PCI: xen-pcifront, fix PCI reference leak

On 2010-11-04 at about 14:31:30 Jiri Slaby wrote:
> Stanse found that when pdev is found and has no driver a reference is
> leaked in pcifront_common_process. So add pci_dev_put there. For the
> pdev == NULL case, pci_dev_put(NULL) is fine.

While that may be true, the dev_err(&pcidev->dev ... is a NULL pointer
deref.

> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Cc: Jesse Barnes <jbarnes@...tuousgeek.org>
> ---
>  drivers/pci/xen-pcifront.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
> index a87c498..f9ffc05 100644
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c
> @@ -578,6 +578,7 @@  static pci_ers_result_t pcifront_common_process(int cmd,
>  	if (!pcidev || !pcidev->driver) {
>  		dev_err(&pcidev->dev,
>  			"device or driver is NULL\n");
> +		pci_dev_put(pcidev);
>  		return result;
>  	}
>  	pdrv = pcidev->driver;
> 

milton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/