linux-kernel - Re: Linux 2.6.37-rc1 (floppy module load: no device found)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 6 Nov 2010 07:52:15 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Jens Axboe <jaxboe@...ionio.com>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.37-rc1 (floppy module load: no device found)

On Sat, Nov 6, 2010 at 5:16 AM, Vivek Goyal <vgoyal@...hat.com> wrote:
>
> While scanning the floopy code, I found one more instance of trying to
> access disk->queue pointer after doing put_disk() on gendisk. For some
> reason, floppy moule still loads/unloads fine. May be object is still
> around with right pointer values.

Yes - the normal use-after-free is fairly silent and only causes
problems if something re-allocates the same memory immediately, which
is quite a small race to hit under normal load.

But if you had had slab poisoning on, you'd have seen the same oops
Randy did (well, not the exact same one since the call trace would be
slightly different due to being from a different point, but _very_
similar).

Anyway, applied.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/