| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 07 Nov 2010 22:31:24 +0100 From: Andi Kleen <andi@...stfloor.org> To: Jim <jim876@...all.nl> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, gcc@....gnu.org Subject: Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ? Jim <jim876@...all.nl> writes: > After upgrading my Dell laptop, both OS+kernel the i8k interface was giving > nonsensical output. As it turned out it's not the kernel but compiler > upgrade which broke this. > > Guys at Archlinux have found the underlying cause (but don't seem to have > submitted a patch yet): > https://bbs.archlinux.org/viewtopic.php?pid=780692#p780692 > gcc seems to optimize the assembly statements away. > > And indeed, applying this patch makes the i8k interface work again, > i.e. replacing the asm(..) construct by asm volatile(..) The compiler really should not optimize the asm away, because it has both input and output arguments which are later used. "asm volatile" normally just means "don't move significantly" I tested it with gcc version 4.5.0 20100604 [gcc-4_5-branch revision 160292] (SUSE Linux) and the asm statement is there for both 32bit and 64bit (with an allmodconfig, with both -O2 and -Os) If gcc 4.5.1 broke that over 4.5.0 you should really file a bug report for the compiler, it seems like a serious regression in 4.5.1 -Andi -- ak@...ux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists