linux-kernel - Re: [PATCH] rtl8712: remove unneeded local variable in _malloc in osdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 7 Nov 2010 07:22:26 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Greg Kroah-Hartman <greg@...ah.com>
cc:	Larry Finger <Larry.Finger@...inger.net>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtl8712: remove unneeded local variable in _malloc in
 osdep_service.h header

On Sun, 7 Nov 2010, Jesper Juhl wrote:

> Hi,
> 
> The local variable 'ret' in 

Arrgh, mixed up two mails I was composing, the above should of course have 
read "The local variable 'pbuf' in"

> drivers/staging/rtl8712/osdep_service.h::_malloc() is completely unneeded, 
> so let's remove it.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
> diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h
>  osdep_service.h |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> index d1674cd..a6e3f19 100644
> --- a/drivers/staging/rtl8712/osdep_service.h
> +++ b/drivers/staging/rtl8712/osdep_service.h
> @@ -196,10 +196,7 @@ static inline void sleep_schedulable(int ms)
>  
>  static inline u8 *_malloc(u32 sz)
>  {
> -	u8 *pbuf;
> -
> -	pbuf =	kmalloc(sz, GFP_ATOMIC);
> -	return pbuf;
> +	return kmalloc(sz, GFP_ATOMIC);
>  }
>  
>  static inline unsigned char _cancel_timer_ex(struct timer_list *ptimer)
> 
> 
> 

-- 
Jesper Juhl <jj@...osbits.net>             http://www.chaosbits.net/
Plain text mails only, please      http://www.expita.com/nomime.html
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/