linux-kernel - Re: [PATCH v2] msm: smd: Reduce driver log chatter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Nov 2010 16:56:29 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Brown <davidb@...eaurora.org>
Cc:	linux-arm-msm@...r.kernel.org,
	Daniel Walker <dwalker@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Brian Swetland <swetland@...gle.com>,
	Arve Hjønnevåg <arve@...roid.com>
Subject: Re: [PATCH v2] msm: smd: Reduce driver log chatter

On Tue, 2010-11-09 at 16:49 -0800, David Brown wrote:
> The MSM smd driver logs numerous messages during startup that are
> useful for debug purposes.  Change these to pr_debug() to match their
> purpose.
> diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
[]
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

If you add this, you probably want to strip
a few prefixes from the formats.

> +
>  #include <linux/platform_device.h>
>  #include <linux/module.h>
>  #include <linux/fs.h>
> @@ -89,7 +91,7 @@ static void smd_diag(void)
[]
> -		pr_info("smem: DIAG '%s'\n", x);
> +		pr_debug("smem: DIAG '%s'\n", x);

probably just
		pr_debug("DIAG '%s'\n", x);

>  	}
>  }
>  
> @@ -312,7 +314,7 @@ static void smd_state_change(struct smd_channel *ch,
[]
> -	pr_info("SMD: ch %d %d -> %d\n", ch->n, last, next);
> +	pr_debug("SMD: ch %d %d -> %d\n", ch->n, last, next);

	pr_debug("ch %d %d -> %d\n", ch->n, last, next);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/