linux-kernel - Re: [PATCH 04/11] hwmon: applesmc: Introduce a register lookup table (rev2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Nov 2010 18:14:38 +0100
From:	Henrik Rydberg <rydberg@...omail.se>
To:	Guenter Roeck <guenter.roeck@...csson.com>
CC:	Jean Delvare <khali@...ux-fr.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/11] hwmon: applesmc: Introduce a register lookup table
 (rev2)

>>

>> Looking at this again, it seems there are two other problems as well. Firstly,
>> the cache memory is not freed after probe failure, my apologies. Secondly,
>> execution continues after a probe failure, and the initialization is retried. I
>> would like to push the latter problem to some other occasion, since the whole
>> platform logic should be rewritten for the new interface, anyways.
>>
> I see the cache problem; this is indeed a tricky one, since it is actually not yet
> a problem after this patch, but will be one after patch 5.
> 
> I don't understand the second problem, though. Looking into the code,
> the probe function will return an error if applesmc_init_smcreg() fails.
> Am I missing something ? What execution continues ?


I think drivers/base/dd.c:142 shows the problem clearly. Basically, the probe
function is supposed to do the proper initialization, if successful. The driver
code has been rewritten heavily since the days of the applesmc, and the actual
probe error is now masked in a rather ugly fashion to allow the driver matching
to continue. It seems to me that the only clean way around this is to actually
implement the correct platform driver logic.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/