linux-kernel - Re: [PATCH v3] msm: smd: Reduce driver log chatter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Nov 2010 10:34:25 -0800
From:	Brian Swetland <swetland@...gle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	David Brown <davidb@...eaurora.org>, linux-arm-msm@...r.kernel.org,
	Daniel Walker <dwalker@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Arve Hjønnevåg <arve@...roid.com>
Subject: Re: [PATCH v3] msm: smd: Reduce driver log chatter

At this point, I think we could just drop the printk()s on the init
functions.  They date back from when we first brought up the driver
and I'm not sure they're of much value at all any more.

Brian

On Wed, Nov 10, 2010 at 10:24 AM, Joe Perches <joe@...ches.com> wrote:
> On Wed, 2010-11-10 at 09:59 -0800, David Brown wrote:
>>  arch/arm/mach-msm/smd.c |   18 ++++++++++--------
>
> Hi again David.  More trivia. Ignore at your pleasure.
>
>>  1 files changed, 10 insertions(+), 8 deletions(-)
>> diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
>
> A moderately common kernel style uses macros like:
>
> #define FUNC_ENTER()    pr_debug("--> %s\n", __func__);
> #define FUNC_EXIT()     pr_debug("<-- %s\n", __func__);
> or
> #define FUNC_ENTER()    pr_debug("Enter %s\n", __func__);
> #define FUNC_EXIT()     pr_debug("Exit  %s\n", __func__);
>
> The macro names vary.
> I've seen enter, _enter, kenter, func_enter, etc.
>
>> @@ -939,7 +941,7 @@ int smsm_set_sleep_duration(uint32_t delay)
>>  int smd_core_init(void)
>>  {
>>       int r;
>> -     pr_info("smd_core_init()\n");
>> +     pr_debug("smd_core_init()\n");
>
>        FUNC_ENTER();
>
>> @@ -992,14 +994,14 @@ int smd_core_init(void)
>>       smsm_change_state(SMSM_STATE_APPS_DEM, ~0, 0);
>>  #endif
>>
>> -     pr_info("smd_core_init() done\n");
>> +     pr_debug("smd_core_init() done\n");
>
>        FUNC_EXIT();
>
>>  static int __devinit msm_smd_probe(struct platform_device *pdev)
>>  {
>> -     pr_info("smd_init()\n");
>> +     pr_debug("smd_init()\n");
>
> wrong function name? FUNC_ENTER();
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/