linux-kernel - Re: [2.6.37-rc1, OOM] virtblk: OOM in do_virtblk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Nov 2010 07:52:54 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Dave Chinner <david@...morbit.com>, mst@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6.37-rc1, OOM] virtblk: OOM in do_virtblk_request()

On Thu, Nov 11, 2010 at 11:16:48AM +1030, Rusty Russell wrote:
> On Thu, 11 Nov 2010 12:01:51 am Christoph Hellwig wrote:
> > Rusty, Michael,
> > 
> > any comments?  I think Dave's observation is correct, and the lack of
> > a mempool for allocations in the virtio stack is a no-go for virtio_blk.
> 
> Interesting.  virtio will try to fall back to using direct ring entries
> if it can, but if course if your request is too large it can never do that.
> 
> So, we could add a memory pool, or restrict the request size in virtio_blk.

The mempool looks like the more generic solution.  Especially as people
are still talking about swap over nfs, at which point virtio-net will
show the same issue (just even harder to reproduce)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/