[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 11 Nov 2010 09:51:10 -0500
From: Bryan Schumaker <bjschuma@...app.com>
To: Catalin Marinas <catalin.marinas@....com>
CC: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
Trond Myklebust <Trond.Myklebust@...app.com>
Subject: Re: [PATCH] nfs: Ignore kmemleak false positive in nfs_readdir_make_qstr
Thanks! The patch works for me.
Bryan
On 11/11/2010 07:53 AM, Catalin Marinas wrote:
> Strings allocated via kmemdup() in nfs_readdir_make_qstr() are
> referenced from the nfs_cache_array which is stored in a page cache
> page. Kmemleak does not scan such pages and it reports several false
> positives. This patch annotates the string->name pointer so that
> kmemleak does not consider it a real leak.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> Cc: Bryan Schumaker <bjschuma@...app.com>
> Cc: Trond Myklebust <Trond.Myklebust@...app.com>
> ---
> fs/nfs/dir.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 07ac384..a9f9e14 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -34,6 +34,7 @@
> #include <linux/mount.h>
> #include <linux/sched.h>
> #include <linux/vmalloc.h>
> +#include <linux/kmemleak.h>
>
> #include "delegation.h"
> #include "iostat.h"
> @@ -231,6 +232,11 @@ int nfs_readdir_make_qstr(struct qstr *string, const char *name, unsigned int le
> string->name = kmemdup(name, len, GFP_KERNEL);
> if (string->name == NULL)
> return -ENOMEM;
> + /*
> + * Avoid a kmemleak false positive. The pointer to the name is stored
> + * in a page cache page which kmemleak does not scan.
> + */
> + kmemleak_not_leak(string->name);
> string->hash = full_name_hash(name, len);
> return 0;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists