[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 11 Nov 2010 10:06:21 +0900
From: "Toshiharu Okada" <toshiharu-linux@....okisemi.com>
To: Michał Nazarewicz <m.nazarewicz@...sung.com>,
"Andy Isaacson" <adi@...apodia.org>
Cc: "Greg Kroah-Hartman" <gregkh@...e.de>,
"LKML" <linux-kernel@...r.kernel.org>,
"linux-usb" <linux-usb@...r.kernel.org>,
"Wang, Qi" <qi.wang@...el.com>,
"Wang, Yong Y" <yong.y.wang@...el.com>,
"Andrew" <andrew.chih.howe.khor@...el.com>,
"Intel OTC" <joel.clark@...el.com>,
"Foster, Margie" <margie.foster@...el.com>,
"Ewe, Kok Howg" <kok.howg.ewe@...el.com>
Subject: Re: [PATCH v7] USB device driver of Topcliff PCH
Hi Michal
Thank you for your comment.
I will modify.
Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)
----- Original Message -----
Date: Wed, 10 Nov 2010 13:29:58 +0100
From: "Michał Nazarewicz" <m.nazarewicz@...sung.com>
>
> In that case, make it:
>
> if (list_empty(&ep->queue)) {
> if (halt) { /* halt or clear halt */
> if (ep->num == PCH_UDC_EP0)
> ep->dev->stall = 1;
> pch_udc_ep_set_stall(ep);
> pch_udc_enable_ep_interrupts(ep->dev, PCH_UDC_EPINT(ep->in, ep->num));
> } else {
> pch_udc_ep_clear_stall(ep);
> }
> ret = 0;
> } else {
> dev_dbg(&dev->pdev->dev, "%s: list not empty", __func__);
> ret = -EAGAIN;
> }
>
> Ie. no need to put "ret = 0;" twice in the code.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists