linux-kernel - Re: [PATCH 7/5] block: clean up blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Nov 2010 19:19:18 +0000
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	axboe@...nel.dk, hch@...radead.org, linux-kernel@...r.kernel.org,
	petero2@...ia.com, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, jack@...e.cz, akpm@...ux-foundation.org,
	adilger.kernel@...ger.ca, tytso@....edu, mfasheh@...e.com,
	joel.becker@...cle.com, aelder@....com, dm-devel@...hat.com,
	drbd-dev@...ts.linbit.com, neilb@...e.de, leochen@...adcom.com,
	sbranden@...adcom.com, chris.mason@...cle.com,
	shaggy@...ux.vnet.ibm.com, joern@...fs.org,
	konishi.ryusuke@....ntt.co.jp, reiserfs-devel@...r.kernel.org,
	viro@...iv.linux.org.uk, philipp.reisner@...bit.com,
	snitzer@...hat.com
Subject: Re: [PATCH 7/5] block: clean up blkdev_get() wrappers and their
 users

Hi,

On Thu, 2010-11-11 at 18:11 +0100, Tejun Heo wrote:
> After recent blkdev_get() modifications, open_by_devnum() and
> open_bdev_exclusive() are simple wrappers around blkdev_get().
> Replace them with blkdev_get_by_dev() and blkdev_get_by_path().
> 
> blkdev_get_by_dev() is identical to open_by_devnum().
> blkdev_get_by_path() is slightly different in that it doesn't
> automatically add %FMODE_EXCL to @mode.
> 
> All users are converted.  Most conversions are mechanical and don't
> introduce any behavior difference.  There are several exceptions.
> 
> * btrfs now sets FMODE_EXCL in btrfs_device->mode, so there's no
>   reason to OR it explicitly on blkdev_put().
> 
> * gfs2, nilfs2 and the generic mount_bdev() now set FMODE_EXCL in
>   sb->s_mode.
> 
> * With the above changes, sb->s_mode now always should contain
>   FMODE_EXCL.  WARN_ON_ONCE() added to kill_block_super() to detect
>   errors.
> 
> The new blkdev_get_*() functions are with proper docbook comments.
> While at it, add function description to blkdev_get() too.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Philipp Reisner <philipp.reisner@...bit.com>
> Cc: Neil Brown <neilb@...e.de>
> Cc: Mike Snitzer <snitzer@...hat.com>
> Cc: Joern Engel <joern@...ybastard.org>
> Cc: Chris Mason <chris.mason@...cle.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: "Theodore Ts'o" <tytso@....edu>
> Cc: KONISHI Ryusuke <konishi.ryusuke@....ntt.co.jp>
> Cc: reiserfs-devel@...r.kernel.org
> Cc: xfs-masters@....sgi.com
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
Acked-by: Steven Whitehouse <swhiteho@...hat.com>

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/