linux-kernel - Re: [tg_shares_up rewrite v2 10/11] sched: allow update_cfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Nov 2010 20:50:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	pjt@...gle.com
Cc:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	mingo@...e.hu, vatsa@...ibm.com, cfriesen@...tel.com,
	svaidy@...ux.vnet.ibm.com, pbourdon@...ellency.fr,
	bharata@...ux.vnet.ibm.com, kmr@...ibm.com,
	balbir@...ux.vnet.ibm.com
Subject: Re: [tg_shares_up rewrite v2 10/11] sched: allow update_cfs_load
 to update global load

From: David Miller <davem@...emloft.net>
Date: Wed, 10 Nov 2010 20:47:04 -0800 (PST)

> From: Paul Turner <pjt@...gle.com>
> Date: Wed, 10 Nov 2010 19:50:15 -0800
> 
>> Refactor the global load updates from update_shares_cpu() so that
>> update_cfs_load() can update global load when it is more than ~10% out of sync.
>> 
>> The new global_load parameter allows us to force an update, regardless of
>> the error factor so that we can synchronize w/ update_shares().
>> 
>> Signed-off-by: Paul Turner <pjt@...gle.com>
> 
> This patch breaks the build, you didn't update the arguments of
> update_cfs_load() in the !CONFIG_FAIR_GROUP_SCHED case.

And even with this fixed there are even larger problems, as you're
making access to structure members such as 'load_unacc_exec_time'
which only exist when CONFIG_FAIR_GROUP_SCHED is set, but you're doing
it in code that is built unconditionally.

Please fix all of these build problems, as I want to test your changes
without all of the group scheduler bloat turned on.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/