linux-kernel - Re: HID: questions about polling rates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Nov 2010 19:31:15 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
cc:	Jiri Kosina <jkosina@...e.cz>, <linux-input@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: HID: questions about polling rates

On Fri, 12 Nov 2010, Stefan Achatz wrote:

> Hello,
> 
> while working on my roccat device drivers I thought about the possiblity
> of on the fly polling rate changes and tested some things.
> 
> First I tried different polling rates by writing values from 1 to 10
> into /sys/bus/usb/drivers/usbhid/module/parameters/mousepoll. I
> observed that the polling rates seem to be capped on both sides. With
> value 1 I measure 2ms instead of 1ms with my hardware protocol
> analyzer. With 10 I get 8ms instead of 10ms.

What type of USB host controller are you using?

The existing drivers (at least, the ones I'm aware of) will only poll
at intervals that are powers of 2.  They won't poll at intervals of 10
ms, for example; the value gets rounded down to 8 ms.  But you should 
be able to poll at intervals of 16 or 32 ms if you want.

There's no reason I know of why you shouldn't be able to poll at 1-ms
intervals.

>  I only use cheap onboard
> usb controllers, but under windows they work with 1ms. A internet and
> code search revealed nothing regarding this to me. Is someone of you
> aware of this behaviour and could tell me more about it?

Note that according to the USB spec, low-speed devices like mice are 
not allowed to request polling intervals shorter than 10 ms.  Of course 
this doesn't matter to you, because you are overriding the device's 
built-in settings.

> Changing the polling rate of a device on the fly would requires to
> use usb_kill_urb() and usb_submit_urb() with new interval. To get the
> int_urb I would need additional informations for incomplete struct
> usbhid_device that lie in drivers/hid/usbhid/usbhid.h. My driver code
> is at home in drivers/hid/. Is it okay to include a header further
> down in the structure? Or does anyone have concerns about moving the
> mentioned header to include/linux? Is this a matter to follow at all?

You can include any header you like in your driver, regardless of where
it lives.  Why do you want to change the polling rate on the fly?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/