lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Nov 2010 12:57:26 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: Greg Thelen <gthelen@...gle.com> Cc: Johannes Weiner <hannes@...xchg.org>, Andrew Morton <akpm@...ux-foundation.org>, Balbir Singh <balbir@...ux.vnet.ibm.com>, Daisuke Nishimura <nishimura@....nes.nec.co.jp>, Wu Fengguang <fengguang.wu@...el.com>, Minchan Kim <minchan.kim@...il.com>, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/6] memcg: make throttle_vm_writeout() memcg aware On Fri, 12 Nov 2010 12:39:35 -0800 Greg Thelen <gthelen@...gle.com> wrote: > > Odd branch ordering, but I may be OCDing again. > > > > if (mem_cgroup && memcg_dirty_info()) > > do_mem_cgroup_stuff() > > else > > do_global_stuff() > > > > would be more natural, IMO. > > I agree. I will resubmit this series with your improved branch ordering. > Hmm. I think this patch is troublesome. This patch will make memcg's pageout routine _not_ throttoled even when the whole system vmscan's pageout is throttoled. So, one idea is.... Make this change == +++ b/mm/vmscan.c @@ -1844,7 +1844,7 @@ static void shrink_zone(int priority, struct zone *zone, if (inactive_anon_is_low(zone, sc)) shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); - throttle_vm_writeout(sc->gfp_mask); + throttle_vm_writeout(sc->gfp_mask, sc->mem_cgroup); } == as == if (!sc->mem_cgroup || throttle_vm_writeout(sc->gfp_mask, sc->mem_cgroup) == not throttled) throttole_vm_writeout(sc->gfp_mask, NULL); Then, both of memcg and global dirty thresh will be checked. -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists