linux-kernel - Re: [RFC][PATCH 1/5] [PATCH 1/5] events: Add EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Nov 2010 07:16:35 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Theodore Tso <tytso@....edu>,
	Arjan van de Ven <arjan@...radead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [RFC][PATCH 1/5] [PATCH 1/5] events: Add EVENT_FS the event
 filesystem

On Tue, 2010-11-16 at 19:32 -0800, Greg KH wrote:
> On Tue, Nov 16, 2010 at 07:53:58PM -0500, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@...hat.com>
> > 
> > Copied mostly from debugfs, the eventfs is the filesystem
> > that will include stable tracepoints. Currently nothing
> > enables this filesystem as of this patch.
> 
> What?  Wait, I wrote tracefs a long time ago just for this, why not take
> that code and use it instead?


Because:

1) I couldn't find it (I thought you called it eventfs, so I was
searching for the wrong thing).

2) You never answered your ping on IRC

3) I was in a rush to get something out.

;-)


I'm perfectly fine in swapping this out. This is only an RFC anyway.
This is also why I Cc'd you on this patch.



> 
> {sigh}  And I just deleted that old tracefs git tree today as I thought
> that idea was long gone and dead....

{sigh} and it may still be dead :-(

-- Steve

> 
> > 
> > Cc: Greg KH <gregkh@...e.de>
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> > ---
> >  fs/Kconfig              |    6 +
> >  fs/Makefile             |    1 +
> >  fs/eventfs/Makefile     |    4 +
> >  fs/eventfs/file.c       |   53 ++++++
> >  fs/eventfs/inode.c      |  433 +++++++++++++++++++++++++++++++++++++++++++++++
> 
> This seems a bit big, I don't think you need all of this for some
> reason.  Are you sure you can't make it smaller?
> 
> thanks,
> 
> greg k-h


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/