linux-kernel - Re: [RFC v1 PATCH 1/6] matrix_keypad: Increase the max limit of rows and columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Nov 2010 09:54:29 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Eric Miao <eric.y.miao@...il.com>
Cc:	Trilok Soni <tsoni@...eaurora.org>, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, rtc-linux@...glegroups.com,
	linux-arm-msm@...r.kernel.org
Subject: Re: [RFC v1 PATCH 1/6] matrix_keypad: Increase the max limit of rows
 and columns

On Wed, Nov 10, 2010 at 03:30:36PM -0800, Dmitry Torokhov wrote:
> On Thu, Nov 11, 2010 at 02:33:45AM +0800, Eric Miao wrote:
> > On Wed, Nov 10, 2010 at 8:47 PM, Trilok Soni <tsoni@...eaurora.org> wrote:
> > > Some keyboard controller have support for more than
> > > 16 columns and rows.
> > >
> > > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > > Cc: Eric Miao <eric.y.miao@...il.com>
> > > Signed-off-by: Trilok Soni <tsoni@...eaurora.org>
> > > ---
> > >  include/linux/input/matrix_keypad.h |    8 ++++----
> > >  1 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h
> > > index 80352ad..d80845e 100644
> > > --- a/include/linux/input/matrix_keypad.h
> > > +++ b/include/linux/input/matrix_keypad.h
> > > @@ -4,11 +4,11 @@
> > >  #include <linux/types.h>
> > >  #include <linux/input.h>
> > >
> > > -#define MATRIX_MAX_ROWS                16
> > > -#define MATRIX_MAX_COLS                16
> > > +#define MATRIX_MAX_ROWS                18
> > > +#define MATRIX_MAX_COLS                18
> > >
> > > -#define KEY(row, col, val)     ((((row) & (MATRIX_MAX_ROWS - 1)) << 24) |\
> > > -                                (((col) & (MATRIX_MAX_COLS - 1)) << 16) |\
> > > +#define KEY(row, col, val)     ((((row) % (MATRIX_MAX_ROWS)) << 24) |\
> > > +                                (((col) % (MATRIX_MAX_COLS)) << 16) |\
> > >                                 (val & 0xffff))
> > >
> > 
> > Or maybe we can solve this completely by introducing something like:
> > 
> > struct matrix_keycode {
> >         int row;
> >         int col;
> >         int value;
> 
> Though that triples the space needed to store initial keymaps.
> 

Looking at it I think we should simply bump up max cols/rows to 32 and
be done with it. It will grow the matrix keypad structure by a few bytes
but nothing drastic.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/