linux-kernel - Re: rcu_read_lock/unlock protect find_task_by_vpid call in migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Nov 2010 09:50:37 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-mm@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>
Cc:	kosaki.motohiro@...fujitsu.com
Subject: Re: rcu_read_lock/unlock protect find_task_by_vpid call in migrate_pages

Hi

> Signed-off-by: Dave Jones <davej@...hat.com>
> 
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 4a57f13..2f0f55b 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1308,6 +1308,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
>  
>  	/* Find the mm_struct */
>  	read_lock(&tasklist_lock);
> +	rcu_read_lock();
>  	task = pid ? find_task_by_vpid(pid) : current;
>  	if (!task) {
>  		read_unlock(&tasklist_lock);
> @@ -1315,6 +1316,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
>  		goto out;
>  	}
>  	mm = get_task_mm(task);
> +	rcu_read_unlock();
>  	read_unlock(&tasklist_lock);
>  
>  	err = -EINVAL;

Thanks reporting. but mmotm seems already has the same patch.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/