linux-kernel - Re: [PATCH 0/7] hid: egalax: Rework to include Joojoo and Wetab support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Nov 2010 12:50:05 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Philipp Merkel <mail@...lmerk.de>,
	Stephane Chatty <chatty@...c.fr>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] hid: egalax: Rework to include Joojoo and Wetab
 support

On Mon, 29 Nov 2010, Henrik Rydberg wrote:

> Hi Jiri,
> 
> This is the second version of this patchset, extended to also support
> the Wetab. The input core changes aside, the patches provide exactly
> the same changes, except for a better signal-to-noise value provided
> by Phillip.
> 
> The first patch is already in your tree, but provided for completeness
> (the present set is against -rc3). The second patch no longer sets up
> the events per packet, since it is handled during slots
> initialization. The third and fourth patch are identical, the fifth
> has that new value, and the sixth is further simplified by using the
> new input core interface. The seventh patch adds support for the
> Wetab.
> 
> The driver has been tested succesfully on all three supported device
> ids.
> 
> Cheers,
> Henrik
> 
> Henrik Rydberg (7):
>   hid: egalax: Use kzalloc
>   hid: egalax: Setup input device manually (rev2)
>   hid: egalax: Correct for device resolution report error (rev2)
>   hid: egalax: Report zero as minimum pressure (rev2)
>   hid: egalax: Add event filtering (rev3)
>   hid: egalax: Convert to MT slots (rev2)
>   hid: egalax: Add support for Wetab
> 
>  drivers/hid/hid-core.c   |    1 +
>  drivers/hid/hid-egalax.c |  129 +++++++++++++++++++---------------------------
>  drivers/hid/hid-ids.h    |    1 +
>  3 files changed, 56 insertions(+), 75 deletions(-)

>From a quick look, it looks basically fine to me, thanks!

Just a very minor nit: it'd be nice to have the Kconfig help text entry 
updated, as the eGalax driver now supports more than what is described 
there.

How are we going to handle this? Dmitry, what is your plan with input-mt 
slots changes?

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/