linux-kernel - Re: [PATCH] Don't spam trace report about missing fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Nov 2010 11:26:45 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Avi Kivity <avi@...hat.com>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-trace-users@...r.kernel.org
Subject: Re: [PATCH] Don't spam trace report about missing fields

On Mon, 2010-11-29 at 18:20 +0200, Avi Kivity wrote:
> Instead of spamming the output with complaints about missing fields, simply
> return an error to the caller, which can print something out or do something
> more intelligent about them.
> 
> Fixes kvm plugin tracing older kernels.

Hmm, what about just passing in err=0?

-- Steve

> 
> Signed-off-by: Avi Kivity <avi@...hat.com>
> ---
>  parse-events.c |   15 +++------------
>  1 files changed, 3 insertions(+), 12 deletions(-)
> 
> diff --git a/parse-events.c b/parse-events.c
> index f0b0324..7a4c3a6 100644
> --- a/parse-events.c
> +++ b/parse-events.c
> @@ -4446,17 +4446,11 @@ int get_field_val(struct trace_seq *s, struct format_field *field,
>  		  const char *name, struct record *record,
>  		  unsigned long long *val, int err)
>  {
> -	if (!field) {
> -		if (err)
> -			trace_seq_printf(s, "<CANT FIND FIELD %s>", name);
> +	if (!field)
>  		return -1;
> -	}
>  
> -	if (pevent_read_number_field(field, record->data, val)) {
> -		if (err)
> -			trace_seq_printf(s, " %s=INVALID", name);
> +	if (pevent_read_number_field(field, record->data, val))
>  		return -1;
> -	}
>  
>  	return 0;
>  }
> @@ -4489,11 +4483,8 @@ void *pevent_get_field_raw(struct trace_seq *s, struct event_format *event,
>  
>  	field = pevent_find_field(event, name);
>  
> -	if (!field) {
> -		if (err)
> -			trace_seq_printf(s, "<CANT FIND FIELD %s>", name);
> +	if (!field)
>  		return NULL;
> -	}
>  
>  	/* Allow @len to be NULL */
>  	if (!len)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/