linux-kernel - Re: [PATCH] staging: easycap: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Nov 2010 18:42:22 +0000
From:	"R.M. Thomas" <rmthomas@...olus.org>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	Greg Kroah-Hartman <gregkh@...e.de>, Michal Marek <mmarek@...e.cz>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: easycap: fix build failure

Jiri Kosina wrote:
> Now, I really believe that this driver is completely hopeless and the only 
> option is complete from-scratch rewrite. I have been looking into it for 
> approximately ~30 seconds (solely to fix this build failure), and I really 
> don't know what to say.

You are quite right of course.  This driver does indeed require a complete
re-write.  The non-standard formatting and (now) redundant debugging macros
are actually the least troublesome issues.  More significant is the need to
replace most of the routines by existing functions from the V4L subsystem.
Unfortunately I shall be unable to undertake this essential work myself in
the foreseeable future owing to other commitments.  Probably the simplest
solution would be to drop the driver from staging.

Even in its present untidy state the driver does work reasonably well on x86
and x86-64, so something could possibly be salvaged from it.

Mike   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/