linux-kernel - Re: [PATCH] Repalce strncmp by memcmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Nov 2010 11:10:17 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Pavel Vasilyev <pavel@...linux.ru>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Repalce strncmp by memcmp

On Mon, Nov 29, 2010 at 05:09:10AM +0300, Pavel Vasilyev wrote:
>
>    This patch replace all strncmp(a, b, c) by  memcmp(a, b, c).
>
>I test on x86_64 (AMD Opteron 285).
>
>#include <string.h>
>char *A = "0000";
>void test_memcmp(void) {
>        memcmp(A, "TEST", 4);
>}
>void test_strn(void) {
>        strncmp(A, "TEST", 4);
>}

This is plain wrong, memcmp() doesn't handle the case that 'a'
is shorter than 'b', it may access beyond '\0'.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/