| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Nov 2010 21:22:51 +0300 From: Cyrill Gorcunov <gorcunov@...il.com> To: Tejun Heo <tj@...nel.org> Cc: linux-kernel@...r.kernel.org, mingo@...hat.com, tglx@...utronix.de, hpa@...or.com, x86@...nel.org, eric.dumazet@...il.com, yinghai@...nel.org, brgerst@...il.com, penberg@...nel.org Subject: Re: [PATCH UPDATED#2 04/16] x86: Use local variable to cache smp_processor_id() in setup_local_APIC() On Tue, Nov 30, 2010 at 07:11:45PM +0100, Tejun Heo wrote: > This is a trivial clean up. > > * Move initialization of @cpu inside preemption disabled region as > suggested by Cyrill Gorcunov. > > Signed-off-by: Tejun Heo <tj@...nel.org> > Cc: Yinghai Lu <yinghai@...nel.org> > Cc: Cyrill Gorcunov <gorcunov@...il.com> > --- > Alright, updated yet again, but I frankly don't see the point in these code structure, if we would be referring variable taken inside preempt off this always look suspicious, i think you agree with me :) > changes. If setup_local_APIC() is being run from a different CPU, we > have a much larger problem. We're already accessing cpu local > resources (tsc, lapic) outside of preemption disabled area. But, > anyways, I don't think it matters one way or the other. > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists