| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Dec 2010 19:51:23 +0100 From: Borislav Petkov <bp@...64.org> To: Florian Mickler <florian@...kler.org> Cc: Tobias Karnat <tobias.karnat@...glemail.com>, Borislav Petkov <bp@...en8.de>, "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: edac_core: crashes on shutdown On Thu, Dec 02, 2010 at 01:14:12PM -0500, Florian Mickler wrote: > Yes. That should work. Once we stopped the workqueue and removed it > from the global list, do we actually need to set it to OP_OFFLINE? I think yes, because we seem to protect ourselves in the actual edac_mc_workq_function() on exit, if we overlap the work items cancellation with the execution of the delayed work at the same time on a different cpu. Besides, it is a single assignment and it does cost us almost nothing. > Also 00740c585 did fix a hang in edac_mc.c... could this also happen > in the edac_device_del_device/edac_pci_del_device functions? Nope, because there we don't check ->op_state when we cancel the work items in the respective _teardown() functions - we simply cancel them unconditionally. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists