lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 05 Dec 2010 14:59:49 +0200 From: Avi Kivity <avi@...hat.com> To: Rik van Riel <riel@...hat.com> CC: vatsa@...ux.vnet.ibm.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Ingo Molnar <mingo@...e.hu>, Anthony Liguori <aliguori@...ux.vnet.ibm.com> Subject: Re: [RFC PATCH 1/3] kvm: keep track of which task is running a KVM vcpu On 12/03/2010 04:16 PM, Rik van Riel wrote: > On 12/03/2010 07:17 AM, Srivatsa Vaddagiri wrote: >> On Thu, Dec 02, 2010 at 02:43:24PM -0500, Rik van Riel wrote: >>> mutex_lock(&vcpu->mutex); >>> + vcpu->task = current; >> >> Shouldn't we grab reference to current task_struct before storing a >> pointer to >> it? > > That should not be needed, since current cannot go away without > setting vcpu->task back to NULL in vcpu_put. > However, you do reference vcpu->task from other contexts. So some sort of safe reference is needed. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists