lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu,  9 Dec 2010 21:55:41 -0600
From:	Fernando Guzman Lugo <fernando.lugo@...com>
To:	<omar.ramirez@...com>
Cc:	<linux-kernel@...r.kernel.org>, <felipe.contreras@...il.com>,
	<nm@...com>, <ohad@...ery.com>,
	Fernando Guzman Lugo <fernando.lugo@...com>
Subject: [PATCHv2 3/4] staging: tidspbridge - remove disabling twl when printing DSP stack

Now the SHM segments are not in lock tlbs, instead
they are in translation tables. So we cannot disable
twl in order to get the DSP stack dump. Also add a check
for __get_free_page allocation.

Signed-off-by: Fernando Guzman Lugo <fernando.lugo@...com>
---
 drivers/staging/tidspbridge/core/ue_deh.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/tidspbridge/core/ue_deh.c b/drivers/staging/tidspbridge/core/ue_deh.c
index 0537edf..183900e 100644
--- a/drivers/staging/tidspbridge/core/ue_deh.c
+++ b/drivers/staging/tidspbridge/core/ue_deh.c
@@ -180,13 +180,8 @@ static void mmu_fault_print_stack(struct bridge_dev_context *dev_context)
 	resources = dev_context->resources;
 	dummy_va_addr = (void*)__get_free_page(GFP_ATOMIC);
 
-	/*
-	 * Before acking the MMU fault, let's make sure MMU can only
-	 * access entry #0. Then add a new entry so that the DSP OS
-	 * can continue in order to dump the stack.
-	 */
-	hw_mmu_twl_disable(resources->dw_dmmu_base);
-	hw_mmu_tlb_flush_all(resources->dw_dmmu_base);
+	if (!dummy_va_addr)
+		return;
 
 	hw_mmu_tlb_add(resources->dw_dmmu_base,
 			virt_to_phys(dummy_va_addr), fault_addr,
-- 
1.7.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ