linux-kernel - Re: [PATCH v4] mach-at91: Support for gsia18s board added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Dec 2010 01:50:48 +0100
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Igor Plyatov <plyatov@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux@...im.org.za, nicolas.ferre@...el.com,
	linux@....linux.org.uk, costa.antonior@...il.com,
	ryan@...ewatersys.com, christian.glindkamp@...kit.de,
	pgsellmann@...tner-elektronik.at
Subject: Re: [PATCH v4] mach-at91: Support for gsia18s board added

On 20:00 Fri 10 Dec     , Igor Plyatov wrote:
> The GS_IA18_S (GMS) is a carrier board from GeoSIG Ltd used with the
> Stamp9G20 SoM from Taskit company.
> It operate as an internet accelerometer.
> 
> Signed-off-by: Igor Plyatov <plyatov@...il.com>
> ---
>  arch/arm/configs/gsia18s_defconfig        |  147 +++++++
please no new defconfig
start to merge them


your patch contain a lots of whitespace please fix it
> +
> +/*
> + * Up to date linux/arch/arm/tools/mach-types database required to support this.
> +MACHINE_START(GSIA18S, "GS_IA18_S")
> +*/
> +MACHINE_START(STAMP9G20, "GS_IA18_S")
if you do this you must use system_rev to identify the board
> +	.boot_params	= AT91_SDRAM_BASE + 0x100,
> +	.timer		= &at91sam926x_timer,
> +	.map_io		= gsia18s_map_io,
> +	.init_irq	= init_irq,
> +	.init_machine	= gsia18s_board_init,
> +MACHINE_END
Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/