linux-kernel - Re: [PATCH] [correction] load fbcon from drm_kms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Dec 2010 23:01:28 +0100
From:	Florian Mickler <mickler@....de>
To:	David Fries <david@...es.net>
Cc:	linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] [correction] load fbcon from drm_kms_helper

On Sun, 12 Dec 2010 12:39:22 -0600
David Fries <david@...es.net> wrote:

> Kconfig says fbcon is required by drm_kms_helper.  If radeon, fbcon,
> and drm_kms_helper are all modules, radeon is auto loaded (by PCI id?),
> drm_kms_helper is loaded because of the module dependency, but fbcon
> isn't loaded leaving the console unusable.  Since fbcon is required
> and there isn't an explicit module dependency, request the module
> to be loaded from drm_kms_helper.
> 
> Signed-off-by: David Fries <david@...es.net>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: dri-devel@...ts.freedesktop.org
> ---
> The last patch had a typo 'namue', mental reminder, test again after
> running checkpatch.pl.
> 
> This solves compiling CONFIG_FB=m and being left with a blank screen
> because the radeon module is automatically loaded, but fbcon isn't.
> If radeon had to be manually loaded, then it would be the user's fault
> for
> not loading fbcon as well, but as radeon is being loaded
> automatically,
> there isn't much a user can do from console to even fix it.  More bug
> details from here,
> https://bugzilla.kernel.org/show_bug.cgi?id=16221

I guess this is reasonable. Maybe _if_ there actually is a usecase for
a drm driver without fbcon, the drm could provide a
parameter to skip loading fbcon?

But also the drm Kconfig seems to be bogus? SELECT is not transitiv. 
So selecting DRM_KMS_HELPER is not enough, as it will not select FB
and FRAMEBUFFER_CONSOLE. Maybe the drm drivers that currently
select DRM_KMS_HELPER should instead depend on it.  

Sincerely,
Flo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/