linux-kernel - fsnotify & sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Dec 2010 13:42:47 +0100
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: fsnotify & sysfs

Hello,

I know that a sysfs file may be pollable but I'm asking to myself how
it could be difficult adding notifying support also.

Maybe adding a call to the fsnotify subsystem within the
sysfs_notify() function as follow can do the trick?

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index da3fefe..afee69f 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -484,8 +486,10 @@ void sysfs_notify(struct kobject *k, const char
*dir, const
                sd = sysfs_find_dirent(sd, NULL, dir);
        if (sd && attr)
                sd = sysfs_find_dirent(sd, NULL, attr);
-       if (sd)
+       if (sd) {
                sysfs_notify_dirent(sd);
+               fsnotify_change(dentry, ATTR_SIZE);
+       }

        mutex_unlock(&sysfs_mutex);
 }

However my problem is how to get the struct dentry pointer needed by
fsnotify_change() related to the struct sysfs_dirent pointer passed to
sysfs_notify(). :(

Can you please give me any advice about to solve it?

Another question: in file linux/fs/sysfs/file.c I see:

   #include <linux/fsnotify.h>

but none of its functions are called into file.c... maybe it's a
mistake?

Thanks in advance,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/